Fix/eth_getBlockByNumber and eth_getUncle... nullable fields #341
Conversation
Date: 2021-03-15 09:53:13-05:00 Signed-off-by: meows <[email protected]>
Date: 2021-03-15 09:56:24-05:00 Signed-off-by: meows <[email protected]>
…ro-value, and filled) Date: 2021-03-15 10:07:04-05:00 Signed-off-by: meows <[email protected]>
Date: 2021-03-15 10:15:24-05:00 Signed-off-by: meows <[email protected]>
Date: 2021-03-15 10:16:52-05:00 Signed-off-by: meows <[email protected]>
Date: 2021-03-15 10:21:40-05:00 Signed-off-by: meows <[email protected]>
…iculty by calculation if DNE Date: 2021-03-15 10:44:45-05:00 Signed-off-by: meows <[email protected]>
Date: 2021-03-15 10:55:14-05:00 Signed-off-by: meows <[email protected]>
…incrementing too big or nil Date: 2021-03-15 11:15:25-05:00 Signed-off-by: meows <[email protected]>
…m/go-ethereum Date: 2021-03-15 13:35:41-05:00 Signed-off-by: meows <[email protected]>
Date: 2021-03-15 14:16:06-05:00 Signed-off-by: meows <[email protected]>
Date: 2021-03-15 14:17:42-05:00 Signed-off-by: meows <[email protected]>
Date: 2021-03-15 14:48:05-05:00 Signed-off-by: meows <[email protected]>
Date: 2021-03-15 14:50:05-05:00 Signed-off-by: meows <[email protected]>
Date: 2021-03-15 14:50:19-05:00 Signed-off-by: meows <[email protected]>
…go-ethereum 1:1 cases Date: 2021-03-15 15:16:47-05:00 Signed-off-by: meows <[email protected]>
Date: 2021-03-15 15:23:31-05:00 Signed-off-by: meows <[email protected]>
Date: 2021-03-15 15:25:59-05:00 Signed-off-by: meows <[email protected]>
|
Ref https://github.com/etclabscore/ethereum.go-ethereum/pull/11/files. This branch shows that Though related, this issue is first concerned with the RPC service (ie server) providing valid information (rather than the Go |
This is just a little over-the-top and too ad-hoc to be worth existence. Date: 2021-03-16 10:33:15-05:00 Signed-off-by: meows <[email protected]>
Date: 2021-03-16 10:55:16-05:00 Signed-off-by: meows <[email protected]>
| hash = &c | ||
| } | ||
| header.TotalDifficulty = (*hexutil.Big)(s.b.GetTd(ctx, *hash)) | ||
| header.TotalDifficulty = (*hexutil.Big)(s.b.GetTd(ctx, *header.Hash)) |
There was a problem hiding this comment.
This now matches the ethereum/go-ethereum implementation.
https://github.com/ethereum/go-ethereum/blob/master/internal/ethapi/api.go#L1187-L1199
|
Re:
I've set it to behave equivalently with ethereum/go-ethereum. This means that it will be included (potentially |
…ocks Create a dedicated type for this case, switching on it conditionally when inclTx is false; this parameter is false only for uncle blocks. Date: 2021-03-17 13:08:01-05:00 Signed-off-by: meows <[email protected]>
…ponses Date: 2021-03-17 13:30:37-05:00 Signed-off-by: meows <[email protected]>
meowsbits
changed the title
|
There was a At first glance it seems unrelated to this change set, but has now happened twice in a row (after 1 re-run). Will look into it tomorrow. |
Rel #334
This is working toward implementing and testing
eth_getBlockByNumberforpendingblocks achieving complete parity with ethereum/go-ethereum (... and with reference to the docs, which seem to be occasionally a source of noise rather than truth).One question remaining concerns the
totalDifficultyfield. Currently (as tested) both core-geth and go-ethereum returnnullfor thependingblock. This field is not present in the docs (cited at above ref'd issue). Logic at the API level determines the existence of this field conditionally on aninclTxesboolean. I'm remembering wrangling with this a while ago, but need to do some more digging to get the details again.